Skip to content

feat(FR-1496): update pulling artifact edge after import revisions #4313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

feat(FR-1496): update pulling artifact edge after import revisions #4313

merged 1 commit into from
Sep 25, 2025
+15 −3

Conversation

@nowgnuesLee
Copy link
Contributor

@nowgnuesLee nowgnuesLee commented Sep 22, 2025 •
edited
Loading

resolves #4308 (FR-1496)

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:S 10~30 LoC label Sep 22, 2025
This was referenced Sep 22, 2025
Merged
Closed
Closed
Merged
Merged
@nowgnuesLee Graphite App
Copy link
Contributor Author

nowgnuesLee commented Sep 22, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nowgnuesLee nowgnuesLee mentioned this pull request Sep 22, 2025
Merged
5 tasks
@nowgnuesLee nowgnuesLee changed the title feat: update pulling artifact edge after import revisions feat(FR-1496): update pulling artifact edge after import revisions Sep 22, 2025
@nowgnuesLee nowgnuesLee marked this pull request as ready for review September 22, 2025 02:49
@github-actions
Copy link

github-actions bot commented Sep 22, 2025 •
edited
Loading

Coverage report for ./packages/backend.ai-ui

St.❔
 Category Percentage Covered / Total
🔴 Statements 52.42% 130/248
🔴 Branches 32.26% 80/248
🔴 Functions 35.09% 20/57
🔴 Lines 54.84% 119/217

Test suite run success

55 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from 176ee48

@nowgnuesLee nowgnuesLee force-pushed the feat/update-pulling-artifact branch from 3451b5c to 4b944ae Compare September 22, 2025 02:52
@nowgnuesLee nowgnuesLee force-pushed the feat/import-notification branch from be8d14e to c7a5adc Compare September 22, 2025 02:52
@github-actions
Copy link

github-actions bot commented Sep 22, 2025 •
edited
Loading

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
4.49% (+0% 🔼)
 501/11170
🔴 Branches
3.64% (-0% 🔻)
 285/7831
🔴 Functions 2.59% 90/3481
🔴 Lines
4.46% (+0% 🔼)
 487/10920

Test suite run success

114 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from 176ee48

@nowgnuesLee nowgnuesLee force-pushed the feat/import-notification branch from c7a5adc to 4bbd42b Compare September 22, 2025 04:16
@nowgnuesLee nowgnuesLee force-pushed the feat/update-pulling-artifact branch 2 times, most recently from 6015b33 to d84973b Compare September 22, 2025 04:19
@nowgnuesLee nowgnuesLee force-pushed the feat/import-notification branch from 4bbd42b to 7962b07 Compare September 22, 2025 04:19
@nowgnuesLee nowgnuesLee force-pushed the feat/import-notification branch from 7962b07 to cc94717 Compare September 22, 2025 11:22
@nowgnuesLee nowgnuesLee force-pushed the feat/update-pulling-artifact branch from d84973b to 5b923f1 Compare September 22, 2025 11:22
@nowgnuesLee nowgnuesLee mentioned this pull request Sep 22, 2025
Merged
5 tasks
@nowgnuesLee nowgnuesLee force-pushed the feat/update-pulling-artifact branch from 5b923f1 to f835903 Compare September 23, 2025 07:18
@nowgnuesLee nowgnuesLee force-pushed the feat/import-notification branch from cc94717 to 482502f Compare September 23, 2025 07:18
@yomybaby yomybaby force-pushed the feat/update-pulling-artifact branch from f835903 to 7e41efa Compare September 23, 2025 09:57
@yomybaby yomybaby force-pushed the feat/import-notification branch from 482502f to 30b7e13 Compare September 23, 2025 09:57
@nowgnuesLee nowgnuesLee force-pushed the feat/import-notification branch from 30b7e13 to bf46406 Compare September 23, 2025 15:25
@nowgnuesLee nowgnuesLee force-pushed the feat/update-pulling-artifact branch from 7e41efa to 17e6099 Compare September 23, 2025 15:25
@nowgnuesLee nowgnuesLee mentioned this pull request Sep 23, 2025
Merged
5 tasks
@nowgnuesLee nowgnuesLee force-pushed the feat/import-notification branch from bf46406 to d977e7c Compare September 25, 2025 04:20
@nowgnuesLee nowgnuesLee force-pushed the feat/update-pulling-artifact branch from 17e6099 to 81e214d Compare September 25, 2025 04:20
@nowgnuesLee nowgnuesLee force-pushed the feat/import-notification branch from d977e7c to f28bdee Compare September 25, 2025 05:05
@nowgnuesLee nowgnuesLee force-pushed the feat/update-pulling-artifact branch from 81e214d to 4dfe10a Compare September 25, 2025 05:06
@nowgnuesLee nowgnuesLee force-pushed the feat/import-notification branch from f28bdee to 711915a Compare September 25, 2025 06:30
@nowgnuesLee nowgnuesLee force-pushed the feat/update-pulling-artifact branch from 4dfe10a to 004a503 Compare September 25, 2025 06:30
@yomybaby yomybaby force-pushed the feat/update-pulling-artifact branch from 004a503 to c9ea4ac Compare September 25, 2025 08:33
@yomybaby yomybaby force-pushed the feat/import-notification branch from 711915a to d34ace3 Compare September 25, 2025 08:33
yomybaby
yomybaby approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app
Copy link

graphite-app bot commented Sep 25, 2025 •
edited
Loading

Merge activity

@nowgnuesLee
feat(FR-1496): update pulling artifact edge after import revisions (#…
176ee48 
…4313)

resolves #4308 (FR-1496)
<!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. -->

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app bot force-pushed the feat/import-notification branch from d34ace3 to 56918ce Compare September 25, 2025 09:02
@graphite-app graphite-app bot force-pushed the feat/update-pulling-artifact branch from c9ea4ac to 176ee48 Compare September 25, 2025 09:03
Base automatically changed from feat/import-notification to main September 25, 2025 09:06
@graphite-app graphite-app bot merged commit 176ee48 into main Sep 25, 2025
9 checks passed
@graphite-app graphite-app bot deleted the feat/update-pulling-artifact branch September 25, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yomybaby yomybaby yomybaby approved these changes

Assignees

@nowgnuesLee nowgnuesLee

Labels

size:S 10~30 LoC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Applying edge appending when pulling

2 participants

@nowgnuesLee @yomybaby